Conversation
ghost
assigned
lidel
force-pushed
the
fix/quic-multiaddr
branch
from
b8a3495 to
6295166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to js-multiaddr from multiformats/js-multiaddr#71 and fixes error from ipfs/ipfs-webui#878 when ipfs-webui is used with API instance from ipfs-companion.
Due to recent release of go-ipfs 0.4.18 a lot of people will may be playing with experimental QUIC transport. The `/quic/ in multiaddr currently breaks Peer page in Web UI and various other dapps,
so I am fast-tracking this to beta channel as a bugfix release as a band-aid until the proper fix is merged upstream.